Author: fschumacher
Date: Mon Jan 26 18:02:11 2015
New Revision: 1654851
URL: http://svn.apache.org/r1654851
Log:
Remove volatile from variables, as it is misleading. All
variables, that are mutable and read/written from different threads are only
modified/read within a synchronized block. All other variables are immutable
and are now declared final. Issue identified by Coverity Scan.
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java?rev=1654851&r1=1654850&r2=1654851&view=diff
==============================================================================
---
tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java
(original)
+++
tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java
Mon Jan 26 18:02:11 2015
@@ -637,10 +637,10 @@ public class DigestAuthenticator extends
}
private static class NonceInfo {
- private volatile long timestamp;
- private volatile boolean seen[];
- private volatile int offset;
- private volatile int count = 0;
+ private final long timestamp;
+ private final boolean seen[];
+ private final int offset;
+ private int count = 0;
public NonceInfo(long currentTime, int seenWindowSize) {
this.timestamp = currentTime;
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
