Hi all,

I looked at the coverity issue 86588 and it says, that the volatile variable seen[] is unsafe, because only the reference is volatile and not not the array elements.

After a closer look, I am convinced, that all variables in that inner class NonceInfo are needlessly declared volatile, since they are either final (well, could be declared final) (this is timestamp) or are only ever accessed inside the constructor and synchronized methods.

I would vote to remove the volatile declarations and add final to timestamp.

Any thoughts?

Felix

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to