https://issues.apache.org/bugzilla/show_bug.cgi?id=44571

--- Comment #4 from Rainer Jung <rainer.j...@kippdata.de> ---
I have changed my opinion. This can be configured using the
connection_pool_size only for the ISAPI redirector. For the common mod_jk case,
"busy" is a global counter, whereas the connection_pool_size is per process.

I have implemented the busy_limit very similar to your original patch in
r1650098.

Some remarks:

- the busy counter is known to have been buggy in the past. I have also aplied
a change to use atomics where available. Since it might still be buggy, I have
flagged the busy_limit feature as experimental in the docs

- I have made it configurable on the AJP or LB member worker, not on the LB
worker itself. This way you can set it to different values for individual LB
members. If you want to set it to the same value for all members, simply add it
to a template using the "reference" feature.

- I decided to reuse the already existing "busy" state of a worker. As a
consequence there's a small change in behavior, even if you don't use
"busy_limit": if a request is sticky, and there's no endpoint available,
previously we nevertheless tried to process the request using the sticky
worker. After this change, we will failover th request (withough marking the
worker as in ERROR). Note that in the default mod_jk (Apache) case, this will
never occur. It can only happen, if you have fewer worker endpoints than
threades, e.g. in the ISAPI or NSAPI case.

Thanks for your contribution.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to