https://issues.apache.org/bugzilla/show_bug.cgi?id=56618

--- Comment #6 from Christopher Schultz <ch...@christopherschultz.net> ---
(In reply to Rainer Jung from comment #5)
> Hi Chris,
> 
> I have applied your patch with some minor variation in r1648934.
> 
> I have removed the dependency on APR, because the same code is used when the
> status worker is called via the ISAPI redirector.

For httpd-based systems, APR will be there, so I figured we could take
advantage of it.

> Since unescape shortens the URL (at least doesn't make it longer), I have
> chosen to do the unescaping in place, i.e. not to copy the original string.

It doesn't save much but its a bit tidier. I did a separate buffer just in case
there was a bug there would be less likelihood of trashing the original query
string. It also allows us to reject a malformed parameter value without
half-decoding it; instead we can use the completely-encoded value in the event
of a failure (though we always fail when the value can't be decoded).

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to