Hi Chris,

Am 30.12.2014 um 20:58 schrieb schu...@apache.org:
Author: schultz
Date: Tue Dec 30 19:58:08 2014
New Revision: 1648589

URL: http://svn.apache.org/r1648589
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48460
- Clarified staggeringly incorrect statement about byte-order
- Fixed bad hex mental math
- Unwound logical confusion about true versus false values and their meanings


Modified:
     tomcat/jk/trunk/xdocs/ajp/ajpv13a.xml

Modified: tomcat/jk/trunk/xdocs/ajp/ajpv13a.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/ajp/ajpv13a.xml?rev=1648589&r1=1648588&r2=1648589&view=diff
==============================================================================
--- tomcat/jk/trunk/xdocs/ajp/ajpv13a.xml (original)
+++ tomcat/jk/trunk/xdocs/ajp/ajpv13a.xml Tue Dec 30 19:58:08 2014
...

@@ -654,8 +652,8 @@ Details:
  <p>
    Signals the end of this request-handling cycle.  If the
    <code>reuse</code> flag is true (==1), this TCP connection can now be used 
to
-  handle new incoming requests.  If <code>reuse</code> is false (anything
-  other than 1 in the actual C code), the connection should be closed.
+  handle new incoming requests.  If <code>reuse</code> is true (anything
+  other than 0 in the actual C code), the connection should be closed.
  </p>
  </subsection>

Are you sure about that change? It doesn't sound logical and also is not how I interprete BZ 48460. To me the comment in BZ indicates, that the meaning of true (reuse TCP) and false (close connection) was OK and should not be changed, but the definition of true should be "anything other than 0 in the actual C code" instead of "==1" and false would be "==0" instead of "anything other than 1 in the actual C code". I haven't checked the impl though.

Regards,

Rainer


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to