Rainer,

On 12/24/14 6:14 PM, rj...@apache.org wrote:
> Author: rjung
> Date: Wed Dec 24 23:14:06 2014
> New Revision: 1647859
> 
> URL: http://svn.apache.org/r1647859
> Log:
> Remove unused defines.
> 
> Modified:
>     tomcat/jk/trunk/native/common/jk_md5.h

I just realized that we had our own implementation of the MD5 algorithm
in mod_jk. :(

Would it be worth trying to detect whether or not the host system has
that routine available in any other way (e.g. OpenSSL)?

I suppose if we must support systems without built-in md5 via OpenSSL or
some other crypto library, we will have to baby-sit that code forever
even if it doesn't get compiled on many targets (e.g. Linux, Mac,
Windows, etc.).

-chris

> Modified: tomcat/jk/trunk/native/common/jk_md5.h
> URL: 
> http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_md5.h?rev=1647859&r1=1647858&r2=1647859&view=diff
> ==============================================================================
> --- tomcat/jk/trunk/native/common/jk_md5.h (original)
> +++ tomcat/jk/trunk/native/common/jk_md5.h Wed Dec 24 23:14:06 2014
> @@ -65,13 +65,6 @@ typedef struct
>      unsigned char buffer[64];       /* input buffer */
>  } JK_MD5_CTX;
>  
> -/*
> - * Define the Magic String prefix that identifies a password as being
> - * hashed using our algorithm.
> - */
> -#define JK_MD5PW_ID "$apr1$"
> -#define JK_MD5PW_IDLEN 6
> -
>  char *JK_METHOD jk_hextocstr(unsigned char *org, char *dst, int n);
>  char *JK_METHOD jk_md5(const unsigned char *org,
>                         const unsigned char *org2, char *dst);
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to