On 22/12/2014 12:34, Konstantin Kolinko wrote: > 2014-12-20 23:32 GMT+03:00 <ma...@apache.org>: >> Author: markt >> Date: Sat Dec 20 20:32:39 2014 >> New Revision: 1647051 >> >> URL: http://svn.apache.org/r1647051 >> Log: >> Remove duplicate utility method. > > > 1). RequestUtil.filter() is used in 404.jsp of manager and > host-manager applications. Those JSP pages have to be fixed as well. > > 2). Actually searching for uses of HttpMessages.filter() method in > Tomcat 8/7/6, it is only used once, in > org.apache.catalina.ssi.SSIMediator.encode(String,String). > > The HttpMessages class is about HTTP protocol reason phrase. > > As such, I think that HTML markup filtering method does not belong > there, and that is better to fix this duplicate code issue in the > opposite way by choosing RequestUtil.filter() as the winner.
Based on 2), I agree with you. I opted for the current approach based on which was more broadly accessible but given that everything that uses this functionality is in o.a.catalina swapping these over makese sense. I'll revert this commit and apply the better fix shortly. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
