2014-11-21 17:57 GMT+03:00 Rémy Maucherat <r...@apache.org>: > Hi, > > I noticed read notifications for websockets are synced (connectionReadLock > in WsFrameBase)
Correction: I suppose that you meant connectionReadLock in WsFrameServer (That is the only place where such name is used in o.a.tomcat.websocket classes) > although the only way it is called is through the read > notification of the upgraded stream. Which means I don't see how any > concurrency can occur. > > However, writes are not synced (the equivalent sync would be in > WsRemoteEndpointImplServer.onWritePossible) although there I believe there > can be some concurrency. Similarly, the buffers field and the individual > buffers could be at risk but it seems less likely. > > Did I miss something ? > > Rémy --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
