https://issues.apache.org/bugzilla/show_bug.cgi?id=57141

Konstantin Kolinko <knst.koli...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #2 from Konstantin Kolinko <knst.koli...@gmail.com> ---
Re: r1636063

I think it is wrong to change ScopedAttributeELResolver to implement this fix.
Thus I am REOPENING this.

The ScopedAttributeELResolver is defined by JSP specification (see JSP.2.9
Resolution of Variables and their Properties) and by its javadoc [1]. Those
describe exactly what it does.

It should not resolve imported classes - those are EL implementation
responsibility, not JSP one.


The EL3.0 specification says in several places that ELResolver is responsible
for resolving "model objects". An imported class is not a model object.

In EL3.0 specification there is chapter 1.5 Resolution of Model Objects and
their Properties or Methods.

[quote]
1.5.3 Evaluating objects with properties

The steps for evaluating an expression with [] or . operators (property
reference and method call) are described in Section 1.6, “Operators [] and .”.
However, the syntax for . operator is also used to reference a static field, or
to invoke a static method. Therefore if the expression with a . operator is not
resolved by the ELResolvers, and if the identifier for the base object is the
name of an imported class, the expression becomes a reference to a static
field, or an invocation of a static method, of the imported class.
[/quote]

Note "Therefore if the expression with a . operator is not resolved by the
ELResolvers" phrase. It is not ELResolver's responsibility to perform a
resolution here.

[1]
http://docs.oracle.com/javaee/7/api/javax/servlet/jsp/el/ScopedAttributeELResolver.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to