Mark and Konstantin,

On 10/23/14 3:53 PM, Konstantin Kolinko wrote:
> 2014-10-13 18:39 GMT+04:00  <ma...@apache.org>:
>> Author: markt
>> Date: Mon Oct 13 14:39:36 2014
>> New Revision: 1631422
>>
>> URL: http://svn.apache.org/r1631422
>> Log:
>> Set encoding so diffs are reported correctly
>>
>> Modified:
>>     tomcat/trunk/java/org/apache/catalina/Lifecycle.java   (props changed)
>>     tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java   (props 
>> changed)
>>
>> Propchange: tomcat/trunk/java/org/apache/catalina/Lifecycle.java
>> ------------------------------------------------------------------------------
>>     svn:mime-type = text/plain; charset=UTF-8
>>
>> Propchange: tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java
>> ------------------------------------------------------------------------------
>>     svn:mime-type = text/plain; charset=UTF-8
>>
> 
> 
> and
> 
>> URL: http://svn.apache.org/r1631406
>> Log:
>> Use UTF-8 to fix ASCII art in Javadoc. How ironic.
> 
> Personally, I do not like the idea of using UTF-8 in java source
> files. That is too fragile. It does not match my OS and IDE default.
> 
> I noted that <javadoc> tasks in Tomcat 8 are configured with
> encoding="ISO-8859-1".  It means that those double angle quotation
> mark characters from http://svn.apache.org/r1631406 become garbage.
> 
> I propose to use "{{" and "}}" as a replacement.

What about embedding a DOT[1] script in the Java source instead of using
ASCII art?

-chris

[1] http://en.wikipedia.org/wiki/DOT_%28graph_description_language%29

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to