On 25/09/2014 20:56, Christopher Schultz wrote: > Some test fail. On my system the "tribes" tests always fail, likely due > to missing multicast support
Yes, that will trigger test failures. > I noticed this during the test-bio run: > > [junit] Write length: 1, Buffered: n, Time: 50309480ns > [junit] Write length: 1, Buffered: y, Time: 63297451ns > [junit] Write length: 10, Buffered: n, Time: 952385ns > [junit] Write length: 10, Buffered: y, Time: 1253882ns > [junit] Write length: 100, Buffered: n, Time: 643847ns > [junit] Write length: 100, Buffered: y, Time: 763425ns > [junit] Write length: 1000, Buffered: n, Time: 616628ns > [junit] Write length: 1000, Buffered: y, Time: 734361ns > [junit] Write length: 10000, Buffered: n, Time: 627050ns > [junit] Write length: 10000, Buffered: y, Time: 723313ns > [junit] Write length: 100000, Buffered: n, Time: 749909ns > [junit] Write length: 100000, Buffered: y, Time: 770355ns > > Whatever we are buffering, it's not helping ;) It isn't expected to. Tomcat is buffering internally so the extra buffer is just overhead. Ideally, we'd check unbuffered it always faster than buffered. > Several tests fail during test-bio, but they all seem to be non-blocking > so maybe they aren't supposed to fail: > > org.apache.catalina.core.ApplicationDispatcher.invoke Servlet.service() > for servlet error threw exception > [junit] javax.servlet.ServletException: Opps. > [junit] at > org.apache.catalina.core.TestAsyncContextImpl$ErrorServlet.doGet(TestAsyncContextImpl.java:1028) > [junit] at > javax.servlet.http.HttpServlet.service(HttpServlet.java:618) > [junit] at > javax.servlet.http.HttpServlet.service(HttpServlet.java:725) > > Note that "oops" is misspelled. :) Those exceptions are all deliberate. As long as the test passes everything is fine. I'll see about fixing that typo. Mark > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
