Author: markt Date: Thu Sep 25 19:33:11 2014 New Revision: 1627608 URL: http://svn.apache.org/r1627608 Log: Review comment 6 from schultz Create correctly sixed StringBuidler for result
Modified: tomcat/trunk/java/org/apache/catalina/realm/CredentialHandlerBase.java Modified: tomcat/trunk/java/org/apache/catalina/realm/CredentialHandlerBase.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/CredentialHandlerBase.java?rev=1627608&r1=1627607&r2=1627608&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/realm/CredentialHandlerBase.java (original) +++ tomcat/trunk/java/org/apache/catalina/realm/CredentialHandlerBase.java Thu Sep 25 19:33:11 2014 @@ -78,7 +78,15 @@ public abstract class CredentialHandlerB String serverCredential = mutate(userCredential, salt, iterations); - return HexUtils.toHexString(salt) + "$" + iterations + "$" + serverCredential; + StringBuilder result = + new StringBuilder(saltLength << 1 + 10 + serverCredential.length() + 2); + result.append(HexUtils.toHexString(salt)); + result.append('$'); + result.append(iterations); + result.append('$'); + result.append(serverCredential); + + return result.toString(); } --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org