https://issues.apache.org/bugzilla/show_bug.cgi?id=56401

--- Comment #5 from Konstantin Kolinko <knst.koli...@gmail.com> ---
Re: r1627296

Could the logging be moved from constructor to Lifecycle.BEFORE_INIT_EVENT,
like activities performed by AprLifecycleListener?


Reason: Doing logging in VersionLoggerListener constructor interferes with
storeconfig feature. IIRC, it instantiates classes to look for their default
properties to omit writing them out.

Steps to reproduce with Tomcat 8.0.14 release candidate and JDK 7u67:

1. Add the following listener to conf/server.xml
  <Listener
className="org.apache.catalina.storeconfig.StoreConfigLifecycleListener"/>

2. Start Tomcat

3. Connect with jconsole, open mbean Catalina/StoreConfig and invoke
"storeConfig()" operation.

4. The following messages are logged for this operation:

[[[
25-Sep-2014 16:38:24.694 INFO [RMI TCP Connection(1)-<IPADDRESS>]
org.apache.catalina.startup.VersionLoggerListener.log Server version: Apache
Tomcat/8.0.14
25-Sep-2014 16:38:24.697 INFO [RMI TCP Connection(1)-<IPADDRESS>]
org.apache.catalina.startup.VersionLoggerListener.log Server built:   Sep 24
2014 09:01:51
25-Sep-2014 16:38:24.699 INFO [RMI TCP Connection(1)-<IPADDRESS>]
org.apache.catalina.startup.VersionLoggerListener.log Server number:  8.0.14.0
25-Sep-2014 16:38:24.700 INFO [RMI TCP Connection(1)-<IPADDRESS>]
org.apache.catalina.startup.VersionLoggerListener.log OS Name:        Windows 7
25-Sep-2014 16:38:24.702 INFO [RMI TCP Connection(1)-<IPADDRESS>]
org.apache.catalina.startup.VersionLoggerListener.log OS Version:     6.1
25-Sep-2014 16:38:24.703 INFO [RMI TCP Connection(1)-<IPADDRESS>]
org.apache.catalina.startup.VersionLoggerListener.log Architecture:   x86
25-Sep-2014 16:38:24.704 INFO [RMI TCP Connection(1)-<IPADDRESS>]
org.apache.catalina.startup.VersionLoggerListener.log JVM Version:   
1.7.0_67-b01
25-Sep-2014 16:38:24.705 INFO [RMI TCP Connection(1)-<IPADDRESS>]
org.apache.catalina.startup.VersionLoggerListener.log JVM Vendor:     Oracle
Corporation
25-Sep-2014 16:38:24.796 INFO [RMI TCP Connection(1)-<IPADDRESS>]
org.apache.catalina.storeconfig.StandardContextSF.storeWithBackup Store Context
 separate with backup (at file
<CATALINA_BASE>\conf\Catalina\localhost\ROOT.xml.2014-09-25.16-38-24 )
25-Sep-2014 16:38:24.829 INFO [RMI TCP Connection(1)-<IPADDRESS>]
org.apache.catalina.storeconfig.StandardContextSF.storeWithBackup Store Context
/manager separate with backup (at file
<CATALINA_BASE>\webapps\manager\META-INF\context.xml.2014-09-25.16-38-24 )
25-Sep-2014 16:38:24.847 INFO [RMI TCP Connection(1)-<IPADDRESS>]
org.apache.catalina.storeconfig.StandardContextSF.storeWithBackup Store Context
/docs separate with backup (at file
<CATALINA_BASE>\conf\Catalina\localhost\docs.xml.2014-09-25.16-38-24 )
25-Sep-2014 16:38:24.865 INFO [RMI TCP Connection(1)-<IPADDRESS>]
org.apache.catalina.storeconfig.StandardContextSF.storeWithBackup Store Context
/examples separate with backup (at file
<CATALINA_BASE>\conf\Catalina\localhost\examples.xml.2014-09-25.16-38-24 )
25-Sep-2014 16:38:24.889 INFO [RMI TCP Connection(1)-<IPADDRESS>]
org.apache.catalina.storeconfig.StandardContextSF.storeWithBackup Store Context
/host-manager separate with backup (at file
<CATALINA_BASE>\webapps\host-manager\META-INF\context.xml.2014-09-25.16-38-24 )
]]]

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to