2014-09-08 2:49 GMT+04:00 <ma...@apache.org>: > Author: markt > Date: Sun Sep 7 22:49:17 2014 > New Revision: 1623243 > > URL: http://svn.apache.org/r1623243 > Log: > Enable the nested blocks check > > Modified: > tomcat/trunk/res/checkstyle/checkstyle.xml > > Modified: tomcat/trunk/res/checkstyle/checkstyle.xml > URL: > http://svn.apache.org/viewvc/tomcat/trunk/res/checkstyle/checkstyle.xml?rev=1623243&r1=1623242&r2=1623243&view=diff > ============================================================================== > --- tomcat/trunk/res/checkstyle/checkstyle.xml (original) > +++ tomcat/trunk/res/checkstyle/checkstyle.xml Sun Sep 7 22:49:17 2014 > @@ -43,9 +43,9 @@ > > value="${tomcat.output}/res/checkstyle/cachefile-checkstyle.xml"/> > > <!-- Block Checks --> > - <!-- ~60 errors > - <module name="AvoidNestedBlocks"/> > - --> > + <module name="AvoidNestedBlocks"> > + <property name="allowInSwitchCase" value="true"/> > + </module> > > <!-- Coding --> > <module name="IllegalInstantiation"/>
FYI: I do not like this change. Limiting the scope of some local variables helps to isolate logic blocks and helps to avoid some copy-paste errors when you forget to rename a helper variable in a copy-pasted block. E.g. http://svn.apache.org/r1623238 http://svn.apache.org/r1623241 There was no technical issues fixed by these changes, so there are not much to discuss here. I am just afraid that forcing such a rule will lead to coding errors. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
