Author: schultz
Date: Tue Aug 26 21:41:47 2014
New Revision: 1620743
URL: http://svn.apache.org/r1620743
Log:
Fixed minor resource-leak [Coverity issue #45132].
Modified:
tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java
Modified: tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java?rev=1620743&r1=1620742&r2=1620743&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java Tue
Aug 26 21:41:47 2014
@@ -18,6 +18,7 @@ package org.apache.catalina.startup;
import java.io.File;
import java.io.FileInputStream;
+import java.io.IOException;
import java.io.InputStream;
import java.net.URL;
import java.util.Enumeration;
@@ -91,11 +92,18 @@ public class CatalinaProperties {
try {
properties = new Properties();
properties.load(is);
- is.close();
} catch (Throwable t) {
handleThrowable(t);
error = t;
}
+ finally
+ {
+ try {
+ is.close();
+ } catch (IOException ioe) {
+ log.warn("Could not close catalina.properties", ioe);
+ }
+ }
}
if ((is == null) || (error != null)) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
