[
https://issues.apache.org/jira/browse/MTOMCAT-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100159#comment-14100159
]
ASF GitHub Bot commented on MTOMCAT-234:
----------------------------------------
GitHub user anenviousguest opened a pull request:
https://github.com/apache/tomcat-maven-plugin/pull/9
MTOMCAT-234 (Tomcat8 plugin is now working) + MTOMCAT-274
Hi,
Don't know how to split this request into two separate ones. Anyway, I
finally got Tomcat 8 plugin passing integration tests.
One thing: it seems that integration tests start embedded Tomcat with
http-nio protocol handler, rather than with http-bio, which means that
assertion statements had to be changed accordingly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anenviousguest/tomcat-maven-plugin tc8.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomcat-maven-plugin/pull/9.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9
----
commit a2e146c785e7f1c964b5d875c78a0bea034dfc78
Author: Vladislav Ponomarev <ponomarevv...@gmail.com>
Date: 2014-08-15T08:12:52Z
1. Fix: MTOMCAT-274 (updated maven-war-plugin version).
2. Fix: access_log.* files excluded from apache-rat-plugin configuration.
These are generated during Tomcat run and should not be checked.
commit 952e3d3f9e0c7d1fcb86cc1594f74ebb3648092e
Author: Vladislav Ponomarev <ponomarevv...@gmail.com>
Date: 2014-08-17T13:26:33Z
Fix: MTOMCAT-234
----
> Tomcat8 Maven Plugin
> --------------------
>
> Key: MTOMCAT-234
> URL: https://issues.apache.org/jira/browse/MTOMCAT-234
> Project: Apache Tomcat Maven Plugin
> Issue Type: Dependency upgrade
> Affects Versions: 2.0, 2.1, 2.2
> Environment: Maven 3.1, Tomcat8.0RC1, Oracle JDK7u25
> Reporter: Petr Novak
> Assignee: Olivier Lamy (*$^¨%`£)
> Priority: Blocker
> Fix For: 3.0
>
>
> Please provide initial version of Tomcat8 Maven Plugin.
> I tried the recommendations in
> http://tomcat.10.x6.nabble.com/Tomcat-8-Tomcat-Maven-Plugin-2-2-Tomcat8-Maven-Plugin-td4995858.html#none
> but the guideline
> http://tomcat.apache.org/maven-plugin-trunk/tomcat7-maven-plugin/adjust-embedded-tomcat-version.html
> does not work for Tomcat8 .
> The problem is in changed Tomcat 8 API, the maven throws folloving exception:
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:142)
> ... 20 more
> by: java.lang.NoSuchMethodError:
> org.apache.catalina.startup.Tomcat.setDefaultRealm(Lorg/apache/catalina/Realm;)V
> at
> org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:999)
> at
> org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:514)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:106)
> ... 20 more
> The method setDefaultRealm is deprecated in Tomcat7 and was removed in
> Tomcat8 as described in documentation:
> http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/startup/Tomcat.html#setDefaultRealm(org.apache.catalina.Realm)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
