On 01/08/2014 13:57, Rémy Maucherat wrote: > Well, it can be disabled easily by reverting back to the old default in > the endpoint. Sorry for all the defects, the code that was submitted was > supposed to be fine ;)
Thanks. I appreciate that. > If you think the feature is too complex and doesn't provide enough benefit, > it can also be removed altogether. I'm still on the fence. I've removed the system property part as that was changing the meaning of some aliases and that might cause a few surprises. On balance I like the idea of the feature and having spent this week getting it into shape I'm reluctant to just delete it. In terms of ensuring correct behaviour, we now have unit tests that demonstrate that all the individual aliases are correct. Next I want to test some more complex expressions to check the operators all behave as expected. Once the unit tests are in place I think I'll be happy about this. We are uncovering differences between the OpenSSL docs and OpenSSL code and I view that as a good sign that the unit tests are thorough. In terms of maintenance, my hope is that the unit tests will spot any change in behaviour between OpenSSL versions. We'll have to see how it goes. If the unit tests work as I hope, then maintenance should not be a big issue. Overall, I think a note is called for in the docs along the lines of this is supported but if the maintenance necessary to keep up with changes in OpenSSL becomes to great it may be deprecated. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
