https://issues.apache.org/bugzilla/show_bug.cgi?id=56770

--- Comment #5 from Martin Knoblauch <kn...@knobisoft.de> ---
Hi Christopher,

 you are talking about this hunk?

@@ -2704,13 +2726,13 @@
          */
         ajp_next_connection(p, l);
     }
+    ajp_update_stats(e, aw, rc, l);
     /* Log the error only once per failed request.
      */
     jk_log(l, JK_LOG_ERROR,
-           "(%s) connecting to tomcat failed.",
-           aw->name);
+           "(%s) connecting to tomcat failed (rc=%d, errors=%d,
client_errors=%d).",
+           aw->name,rc,aw->s->errors,aw->s->client_errors);

-    ajp_update_stats(e, aw, rc, l);
     JK_TRACE_EXIT(l);
     return rc;

Sorry for not mentioning it in the description. The explanation is simple.

Before the addition of the rc/errors/client_errors fields to the log it did not
matter where the call to update_stats occurred relative to the logging. Now we
want to display the updated numbers - at least I think so, therefore the call
to update_stats needs to happen before the logging.

Cheers
Martin

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to