Author: olamy
Date: Wed Jul 23 04:00:48 2014
New Revision: 1612753

URL: http://svn.apache.org/r1612753
Log:
implemented proxy fix for tomcat6-maven-plugin

Modified:
    
tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/deployer/TomcatManager.java
    
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/AbstractCatalinaMojo.java

Modified: 
tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/deployer/TomcatManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/deployer/TomcatManager.java?rev=1612753&r1=1612752&r2=1612753&view=diff
==============================================================================
--- 
tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/deployer/TomcatManager.java
 (original)
+++ 
tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/deployer/TomcatManager.java
 Wed Jul 23 04:00:48 2014
@@ -199,7 +199,6 @@ public class TomcatManager
 
             String host = url.getHost();
             int port = url.getPort() > -1 ? url.getPort() : AuthScope.ANY_PORT;
-
             httpClient.getCredentialsProvider().setCredentials( new AuthScope( 
host, port ), creds );
 
             AuthCache authCache = new BasicAuthCache();
@@ -293,7 +292,6 @@ public class TomcatManager
      */
     private void applyProxy() {
        if( this.proxy != null ) {
-               System.out.println("proxy: " + proxy);
                HttpHost proxy = new HttpHost(this.proxy.getHost(), 
this.proxy.getPort(), this.proxy.getProtocol());
                httpClient.getParams().setParameter( 
ConnRoutePNames.DEFAULT_PROXY, proxy );
                if( this.proxy.getUsername() != null ) {

Modified: 
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/AbstractCatalinaMojo.java
URL: 
http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/AbstractCatalinaMojo.java?rev=1612753&r1=1612752&r2=1612753&view=diff
==============================================================================
--- 
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/AbstractCatalinaMojo.java
 (original)
+++ 
tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/AbstractCatalinaMojo.java
 Wed Jul 23 04:00:48 2014
@@ -20,9 +20,11 @@ package org.apache.tomcat.maven.plugin.t
  */
 
 import org.apache.maven.artifact.manager.WagonManager;
+import org.apache.maven.execution.MavenSession;
 import org.apache.maven.plugin.MojoExecutionException;
 import org.apache.maven.plugins.annotations.Component;
 import org.apache.maven.plugins.annotations.Parameter;
+import org.apache.maven.settings.Proxy;
 import org.apache.maven.wagon.authentication.AuthenticationInfo;
 import org.apache.tomcat.maven.common.deployer.TomcatManager;
 import org.apache.tomcat.maven.common.deployer.TomcatManagerException;
@@ -69,6 +71,12 @@ public abstract class AbstractCatalinaMo
      */
     @Component( role = WagonManager.class )
     private WagonManager wagonManager;
+    
+    /**
+     * The current build session instance. This is used for plugin manager API 
calls.
+     */
+    @Component
+    private MavenSession session;
 
     /**
      * The full URL of the Tomcat manager instance to use.
@@ -216,6 +224,12 @@ public abstract class AbstractCatalinaMo
 
             manager = new TomcatManager( url, userName, password, charset, 
settings.isInteractiveMode() );
             manager.setUserAgent( name + "/" + version );
+            
+            Proxy proxy = session.getSettings().getActiveProxy();
+            if( proxy != null && proxy.isActive() ) {
+               getLog().debug("proxy: " + proxy.getHost() + ":" + 
proxy.getPort());
+               manager.setProxy(proxy);
+            }
         }
 
         return manager;



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to