Hi!

Steps to reproduce:
1) Start one instance of Tomcat 8
2) Start second instance of Tomcat 8
3) The second instance shuts down (as expected), but the following
NPEs are logged into catalina.$date.log, both for HTTP and AJP
connectors:
[[[
08-Jul-2014 14:50:25.589 SEVERE [main]
org.apache.coyote.AbstractProtocol.stop Failed to stop end point
associated with ProtocolHandler ["http-nio-8080"]
 java.lang.NullPointerException
    at org.apache.tomcat.util.net.NioEndpoint.stopInternal(NioEndpoint.java:457)
    at 
org.apache.tomcat.util.net.AbstractEndpoint.stop(AbstractEndpoint.java:783)
....
]]]

The line is "eventCache.clear();" and the cause are changes in r1603376.

Re-reviewing r1603376:
- the only difference for NioEndpoint is that creation of caches is
deferred from constructor to startInternal().
- for Nio2Endpoint the creation is deferred and now depends on useCaches flag.

Is there a point in deferring creation of caches for Nio? Was there an
idea to make creation dependent on some flag ("useCaches"), like it is
done for Nio2?

If there is no point in deferring, then reverting that part of
r1603376 is a way to go. If there is, then adding null pointer checks
is the way to go.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to