2014-07-02 14:33 GMT+04:00 <r...@apache.org>: > Author: remm > Date: Wed Jul 2 10:33:49 2014 > New Revision: 1607309 > > URL: http://svn.apache.org/r1607309 > Log: > Trivial change to add configuration fields to SSLValve for header names. > > Modified: > tomcat/trunk/java/org/apache/catalina/valves/SSLValve.java > tomcat/trunk/webapps/docs/changelog.xml >
1) It needs documentation. (docs/config/valve.html) 2) I wonder if there is a need for the new fields to be "protected" rather than "private" when they have setters and getters. (Just saying. Not a stopper). Best regards, Konstantin Kolinko > Modified: tomcat/trunk/java/org/apache/catalina/valves/SSLValve.java > URL: > http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/SSLValve.java?rev=1607309&r1=1607308&r2=1607309&view=diff > ============================================================================== > --- tomcat/trunk/java/org/apache/catalina/valves/SSLValve.java (original) > +++ tomcat/trunk/java/org/apache/catalina/valves/SSLValve.java Wed Jul 2 > 10:33:49 2014 > @@ -64,6 +64,10 @@ public class SSLValve extends ValveBase > > private static final Log log = LogFactory.getLog(SSLValve.class); > > + protected String sslClientCertHeader = "ssl_client_cert"; > + protected String sslCipherHeader = "ssl_cipher"; > + protected String sslSessionIdHeader = "ssl_session_id"; > + protected String sslCipherUserKeySizeHeader = "ssl_cipher_usekeysize"; --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
