2014-06-26 14:18 GMT+04:00 <r...@apache.org>:
> Author: remm
> Date: Thu Jun 26 10:18:07 2014
> New Revision: 1605724
>
> URL: http://svn.apache.org/r1605724
> Log:
> Improve exception routing so that a thrown exception interrupts the store
> process (avoid server.xml overwrite with a broken one).
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/storeconfig/IStoreConfig.java
> tomcat/trunk/java/org/apache/catalina/storeconfig/LocalStrings.properties
> tomcat/trunk/java/org/apache/catalina/storeconfig/StoreConfig.java
> tomcat/trunk/webapps/docs/changelog.xml
>
1. This commit removed two methods from StoreConfig class:
public synchronized void storeServer(String aServerName, boolean backup,
boolean externalAllowed) throws MalformedObjectNameException {
public synchronized void storeContext(String aContextName, boolean backup,
boolean externalAllowed) throws MalformedObjectNameException {
Those methods are still listed in mbeans-descriptors.xml file.
2. Behaviour of StoreConfig.store(Context aContext) in case if
Context.getConfigFile() is null
In general that is a possible configuration (there was no xml file
when Context started). Does it need a "log.error()"?
My question does not make sense if in this case the call to store()
method is skipped somewhere at a higher level. If the call is
normally skipped then the error() logging here is justified.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
