2014-06-26 15:40 GMT+04:00 Rémy Maucherat <r...@apache.org>: > 2014-06-26 13:32 GMT+02:00 Konstantin Kolinko <knst.koli...@gmail.com>: > >> What are the circumstances when this NPE happens? >> >> StandardRoot.initInternal() throws an IllegalStateException if the >> context is null. How can it be without a context? >> > > "Avoid NPE with storeconfig": storeconfig creates instances to determine > default values for properties.
(Just from description. I do not know, maybe there is already some special processing for this case in the storeconfig code). I this case the logic is flawed 1. Even though there is a setter (LifecycleMBeanBase.setDomain()), this value is not expected to be configured in a configuration file. 2. The default value in this case is not Globals.DEFAULT_MBEAN_DOMAIN (as will be returned by LifecycleMBeanBase.getDomain() with this patch), but context.getDomain() (for StandardRoot), parent.getDomain() (for ContainerBase). Ultimately it is StandardEngine.getDomainInternal() which returns getName(). So if the Engine has a non-default name, will there be domain="" properties written everywhere in the configuration files? So my expectation is that the "domain" property has to be ignored by storeconfig. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
