2014-06-14 14:29 GMT+04:00 Konstantin Kolinko <knst.koli...@gmail.com>: > 2014-06-11 0:47 GMT+04:00 Mark Thomas <ma...@apache.org>: >> On 10/06/2014 21:01, Konstantin Kolinko wrote: >>> 2014-06-10 18:06 GMT+04:00 Mark Thomas <ma...@apache.org>: >>>> On 10/06/2014 10:52, ma...@apache.org wrote: >>>>> Author: markt >>>>> Date: Tue Jun 10 09:52:56 2014 >>>>> New Revision: 1601590 >>>>> >>>>> URL: http://svn.apache.org/r1601590 >>>>> Log: >>>>> Pull up AsyncTimeout >>>>> APR/native used a separate flag to stop the thread. This avoided issues >>>>> where running was set true->false-true in quick succession. This fix is >>>>> now available to NIO2 and BIO as well. >>>>> Note NIO does not (currently) use the AsyncTimeout >>>> >>>> The Async unit test is currently taking 15 mins per test. I'm guessing >>>> that I broke something in the async timeouts with this refactoring. I'm >>>> looking now. >>> >>> http://svn.apache.org/r1601443 >>> is suspicious for me. >>> Was there a reason to add "if (socket.isAsync())" around timeout processing? >> >> Agreed. That was where I looked first too. I added it as APR had it when >> I was aligning the code prior to the refactoring. On further review, I >> opted to remove it. >> > > For a record (regarding your comment on r1601761 that reverted r1601443)
Correcting myself... > s/APR/BIO/ > > r1601443 added "if (socket.isAsync())" to both APR and BIO. Correction: r1601443 added it to BIO and NIO2. The condition was already present in APR. The code (the AsyncTimeout inner class) was absent in NIO. The "if (socket.isAsync())" condition in AsyncTimeout.run() of APR endpoint originates from r1006358. That is what Mark's commit comment on r1601761 was about. > For BIO that was fatal, because it is always returns "false". > The reason is that there are no calls to socket.setAsync(true) in BIO > connector code. > > APR change cannot cause a Buildbot or Gump failure, because they do > not run APR tests. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
