GitHub user hanyong opened a pull request:

    https://github.com/apache/tomcat/pull/10

    Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56518

    In NioEndpoint, save and retrieve SelectionKey in KeyAttachment.
    When the socket is closed by the interrupt,
    the associated SelectionKey may be removed by the poller thread before 
async complete.
    Then socket.keyFor() returns null, the connection count would not be 
reduced.
    Save the key in the attachment could fix this.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hanyong/tomcat bugfix-56518

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomcat/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10
    
----
commit 06e218f7f6c845d96522f0bcd987096c18c9ab8c
Author: 涧泉 <observer.h...@alibaba-inc.com>
Date:   2014-06-09T04:21:48Z

    Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56518
    
    In NioEndpoint, save and retrieve SelectionKey in KeyAttachment.
    When the socket is closed by the interrupt,
    the associated SelectionKey may be removed by the poller thread before 
async complete.
    Then socket.keyFor() returns null, the connection count would not be 
reduced.
    Save the key in the attachment could fix this.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to