2014-05-31 16:12 GMT+04:00 <rj...@apache.org>: > Author: rjung > Date: Sat May 31 12:12:36 2014 > New Revision: 1598864 > > URL: http://svn.apache.org/r1598864 > Log: > Reduce log level for "OPTIONS *" requests > from warning to debug. > > Modified: > tomcat/jk/trunk/native/common/jk_uri_worker_map.c > tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml > > Modified: tomcat/jk/trunk/native/common/jk_uri_worker_map.c > URL: > http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_uri_worker_map.c?rev=1598864&r1=1598863&r2=1598864&view=diff > ============================================================================== > --- tomcat/jk/trunk/native/common/jk_uri_worker_map.c (original) > +++ tomcat/jk/trunk/native/common/jk_uri_worker_map.c Sat May 31 12:12:36 2014 > @@ -1093,8 +1093,14 @@ const char *map_uri_to_worker_ext(jk_uri > if (index) > *index = -1; > if (*uri != '/') { > - jk_log(l, JK_LOG_WARNING, > - "Uri %s is invalid. Uri must start with /", uri); > + if (*uri == '*' && *(uri+1) == '\0' && JK_IS_DEBUG_LEVEL(l)) { > + /* Most likely an "OPTIONS *" request */ > + jk_log(l, JK_LOG_DEBUG, > + "Uri %s can't be mapped.", uri); > + } else { > + jk_log(l, JK_LOG_WARNING, > + "Uri %s is invalid. Uri must start with /", uri); > + }
I think the above if/else is wrong: you cannot combine business and debug conditions in the same "if". This makes "else" branch misplaced. (If debug logging is off, the else branch will execute). > JK_TRACE_EXIT(l); > return NULL; > } > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
