Author: markt Date: Mon May 12 16:13:14 2014 New Revision: 1594018 URL: http://svn.apache.org/r1594018 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56513 Make it crystal clear that using sendfile will disable any compression that might otherwise have been used.
Modified: tomcat/trunk/webapps/docs/aio.xml tomcat/trunk/webapps/docs/changelog.xml tomcat/trunk/webapps/docs/config/http.xml Modified: tomcat/trunk/webapps/docs/aio.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/aio.xml?rev=1594018&r1=1594017&r2=1594018&view=diff ============================================================================== --- tomcat/trunk/webapps/docs/aio.xml (original) +++ tomcat/trunk/webapps/docs/aio.xml Mon May 12 16:13:14 2014 @@ -348,6 +348,11 @@ Tomcat will not do that for you, since you may have already written data to the output stream. </p> + <p> + Note that the use of sendfile will disable any compression that Tomcat may + otherwise have performed on the response. + </p> + </section> </body> Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1594018&r1=1594017&r2=1594018&view=diff ============================================================================== --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Mon May 12 16:13:14 2014 @@ -357,6 +357,11 @@ <update> Improve valves documentation. Split valves into groups. (kkolinko) </update> + <fix> + <bug>56513</bug>: Make the documentation crystal clear that using + sendfile will disable any compression that Tomcat may otherwise have + applied to the response. (markt) + </fix> </changelog> </subsection> <subsection name="Other"> Modified: tomcat/trunk/webapps/docs/config/http.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/http.xml?rev=1594018&r1=1594017&r2=1594018&view=diff ============================================================================== --- tomcat/trunk/webapps/docs/config/http.xml (original) +++ tomcat/trunk/webapps/docs/config/http.xml Mon May 12 16:13:14 2014 @@ -668,7 +668,9 @@ <attribute name="useSendfile" required="false"> <p>(bool)Use this attribute to enable or disable sendfile capability. - The default value is <code>true</code>.</p> + The default value is <code>true</code>. Note that the use of sendfile + will disable any compression that Tomcat may otherwise have performed on + the response.</p> </attribute> <attribute name="socket.directBuffer" required="false"> @@ -801,7 +803,9 @@ <attribute name="useSendfile" required="false"> <p>(bool)Use this attribute to enable or disable sendfile capability. - The default value is <code>true</code>.</p> + The default value is <code>true</code>. Note that the use of sendfile + will disable any compression that Tomcat may otherwise have performed on + the response.</p> </attribute> <attribute name="socket.directBuffer" required="false"> @@ -951,7 +955,9 @@ <attribute name="useSendfile" required="false"> <p>(bool)Use this attribute to enable or disable sendfile capability. - The default value is <code>true</code>.</p> + The default value is <code>true</code>. Note that the use of sendfile + will disable any compression that Tomcat may otherwise have performed on + the response.</p> </attribute> </attributes> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org