https://issues.apache.org/bugzilla/show_bug.cgi?id=56492

--- Comment #3 from Sylvain Laurent <slaur...@apache.org> ---
(In reply to Christopher Schultz from comment #2)
> My question would be why there is an exception thrown here to handle this
> case at all. Instead, why not check to see if we should die cleanly, then
> emit the recycling message to the log and simply exit the run method?
> 
> I don't understand why an exception is being used here at all.

Because actually in normal operation those threads never go out of
java.util.concurrent.ThreadPoolExecutor.runWorker(Worker) unless there are more
threads than the corePoolSize and the task queue is empty.

So, when I worked on the renewal of threads to avoid classloader leaks upon
undeployment, the only way I found was to throw an exception in our
implementation of ThreadPoolExecutor.afterExecute(Runnable, Throwable).

Is it OK for me to commit on tomcat 8 trunk?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to