Author: kkolinko
Date: Thu Apr 17 13:43:05 2014
New Revision: 1588248

URL: http://svn.apache.org/r1588248
Log:
votes

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1588248&r1=1588247&r2=1588248&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Apr 17 13:43:05 2014
@@ -105,11 +105,20 @@ PATCHES PROPOSED TO BACKPORT:
   http://svn.apache.org/viewvc?view=revision&revision=r1587723 (adapt)
   (Note: requires tcnative 1.1.30)
   +1: schultz, markt
+  +0: kkolinko:
+       a) It needs backport of r1588102 as an Exception is thrown by native 
code
+
+       b) "enterFipsMode = 1 != fipsModeState;" code and comment before it are 
wrong.
+
+          FIPS_mode() function of OpenSSL is documented to return non-zero
+          value when in FIPS mode. You cannot expect it to be '1'.
+          Reference:
+           http://wiki.openssl.org/index.php/FIPS_mode%28%29
   -1:
 
 * Avoid memory leak and add small optimisation to default Servlet
   http://svn.apache.org/r1588199
-  +1: markt 
+  +1: markt, kkolinko
   -1:
 
 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to