Github user kkolinko commented on the pull request:
https://github.com/apache/tomcat/pull/5#issuecomment-40340077
1. Bugzilla issue = ?
(with Tomcat version, steps to reproduce etc.)
2. The patch (https://github.com/apache/tomcat/pull/5.patch) is a mess,
with deletions and additions. That will break svn history for those files
if applied.
3
- if( deadMaxTime < rp.getMaxTime() )
+ if( deadMaxTime < rp.getMaxTime() ) {
deadMaxTime = rp.getMaxTime();
+ deadMaxStartTime = rp.getMaxStartTime();
+ }
I would expect "maxStartTime" to be a maximum of its own value, but here
you are calculating it from "maxTime".
4. Is this information visible on the "Status" page of the Manager webapp?
Maybe a patch will be needed there.
5. Is this information visible in jconsole?
(6. Maybe some documentation update will be needed (depends on 4. and 5.),
e.g. IIRC there is a page describing Tomcat JMX objects on the wiki.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
