On 11.04.2014 15:17, Mladen Turk wrote:
> Hi,
> 
> Apache Tomcat Connectors 1.2.40 release candidate is ready
> for vote at [1]. The build was done using tag [2].
> This version is bugfix release, fixing some issues
> found in version 1.2.39.
> 
> 
> The VOTE will remain open for at least 48 hours.
> 
> The Apache Tomcat Connectors 1.2.40 is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...

+1

Details:

- Sigs and hashes OK
- key in KEYS file
  - key is only signed by Jean-Frederic, would be good to
    find a few more people to sign it for the web of trust
- gz and zip for src identical
- src consistent with svn tag, except for the following expected deltas:
  - LICENSE and NOTICE moved one directory up (OK)
  - KEYS not in dist (OK)
  - deprectated jk2 xdocs missing in dist (OK)
  - additional generated files in dist: aclocal.m4, configure,
    Makefile.in, config.h.in, html docs in dist (OK)
  - additional auto tool copied files in dist: install-sh, ltmain.sh,
    missing (OK)
  - build.properties.autoconf, native/build.xml and the jkant directory
    missing from dist.

Builds succesfully on all tested platforms:

- Solaris 8 Sparc using gcc 4.1.2 as 32 Bit Binaries for 1.3, 2.0, 2.2
- Solaris 10 Sparc using gcc 4.8.2 as 32 Bit Binaries for 2.4
- SLES 10 64 bit using platform gcc for 1.3, 2.0, 2.2
- SLES 10 32 bit using platform gcc for 2.2
- SLES 11 64 bit using platform gcc for 2.2, 2.4
- RHEL 5 64bit using platform gcc for 2.2
- SLES 6 64 bit using platform gcc for 2.2, 2.4

using CFLAGS: -O2 -g -Wall -fno-strict-aliasing
(and -mpcu=v9 on Solaris)

Additional observations (not a regression, affected file list slightly
different from 1.2.37):

- File ltmain.sh in src tar and zip has perms 644 instead of 755 (not a
regression).

- Some build warnings because we use defines coming from auto tools
which overlap with httpd defines:

In file included from ../common/jk_global.h:29:0,
                 from mod_jk.c:89:
../common/config.h:77:0: warning: "PACKAGE_NAME" redefined [enabled by
default]
 #define PACKAGE_NAME "mod_jk"
 ^
In file included from .../apache/include/ap_config.h:138:0,
                 from mod_jk.c:29:
.../apache/include/ap_config_auto.h:213:0: note: this is the location of
the previous definition
 #define PACKAGE_NAME ""
 ^

The same for PACKAGE_STRING, PACKAGE_TARNAME and PACKAGE_VERSION.

I haven't checked how easy it would be to rename them or if they have
some fixed meaning with auto tools.

Regards,

Rainer


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to