https://issues.apache.org/bugzilla/show_bug.cgi?id=56382

--- Comment #2 from Konstantin Kolinko <knst.koli...@gmail.com> ---
Comment on attachment 31506
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31506
Proposed patch

In reply to attachment 31506

>         if( log.isInfoEnabled() )
> +            startTime = System.currentTimeMillis();
>             log.info(sm.getString("hostConfig.deployDir",
>                     dir.getAbsolutePath()));

1. The above change breaks the code, because of missing '{' after an 'if'
above.

> System.currentTimeMillis() - startTime

2. Boxing and unboxing have to be explicit, per our coding rules.

3. This covers only 'deployDirectory(..)' method. What about the others?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to