On 17/03/2014 15:08, Mark Thomas wrote: > On 17/03/2014 14:42, Konstantin Kolinko wrote: >> 2014-03-17 16:19 GMT+04:00 Mark Thomas <ma...@apache.org>: >>> Hi, >>> >>> It has been a while since 8.0.3 and the change log is looking rather >>> long. I've a few things left I want to look at but I expect to be in a >>> position to tag 8.0.4 late today / early tomorrow. >>> >> >> There is >> https://issues.apache.org/bugzilla/show_bug.cgi?id=56265 >> "Unexpected escaping in the values of dynamic tag attributes >> containing EL expressions" >> >> Regarding my v1 patch attached there, I think there is more to it. >> That is: in the method changed by that patch, I think the 'false' >> branch of "if (el.containsEL()) {" needs to have the same xmlEscaping >> processing as the 'true' branch does for >> "if (n instanceof Node.UninterpretedTag && n.getRoot().isXmlSyntax()) " >> nodes. >> >> As of now attributes of uninterpreted XML tags that are plain text >> without EL expressions are either escaped elsewhere (I have not found >> where, but that would split the escaping logic between two places in >> the code), or not at all. >> >> Looking at Generator.java L1806 >> ( Generator$GenerateVisitor.visit(Node.UninterpretedTag n) ), >> it does escape double quotes there, but nothing else. >> >> >> I'll work on test cases. > > I'll add this to my things to look at before I tag 8.0.4.
This has been fixed with Konstantin's patch. I'm currently running the unit tests on Windows, Linix and OSX. I plan to tag 8.0.4 once those tests all pass. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
