https://issues.apache.org/bugzilla/show_bug.cgi?id=56248

Konstantin Kolinko <knst.koli...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #3 from Konstantin Kolinko <knst.koli...@gmail.com> ---
Reviewing r1577199

Besides two small issues that I mentioned in "Re: r1577199" thread on dev@, and
bug 56273, one more high-level one:

The logic in update=true case in
    protected synchronized void deploy
        (PrintWriter writer, ContextName cn,
         String tag, boolean update, HttpServletRequest request,
         StringManager smClient) {

is as follows:
1. mark webapp as serviced
2. delete old war
3. upload new war,
 that means to read the body of a PUT request and save it as file
4. trigger deployment, remove serviced mark

If step 3. fails due to aborted I/O, the old application will become
undeployed, deleting its custom configuration if there is any.

It would be better to upload it to a temporary name and rename the file.
A temporary name can be created with java.io.File.createTempFile(,,dir).

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to