https://issues.apache.org/bugzilla/show_bug.cgi?id=56213

--- Comment #2 from Konstantin Kolinko <knst.koli...@gmail.com> ---
Regarding this change ( r1574484 ) I would like to hear, whether it really
improves situation for you.

KeyReference is just a reference object. Reusing and recycling it via a queue
creates another reference object that holds it in the queue
(ConcurrentLinkedQueue$Node, in queue.offer()). These Node objects are created
on each offer and are not reused.

So, amount of garbage is exactly the same, but some processing cost is added.

My guess is that Node objects are more short-lived and thus are collected more
easily. Also they do not have a finalize() method and can be disposed of in one
step without going through a finalizer queue. So the only difference is in the
kind of garbage.

Is it worth it?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to