On 02/26/2014 02:30 PM, Rainer Jung wrote:
On 26.02.2014 11:48, Mladen Turk wrote:
native/nt_service/jk_nt_service.c still uses jk_resolve() with
sockaddr_in instead of tne new jk struct. Should we remove
native/nt_service or apply the probably simple fix to make it compatible
with the new jk structs? I'd say we can drop it but should add it to
changes and news. I don't remember anyone having askes about it for many
years and I'm not even convinced it worked in 1.2.37.
Yes. We should have drop this a long time ago.
I'll axe the code and add the changelog entry.
JK_INET / JK_INET6: it looks a bit confusing to me.
- JK_INET is set to APR_INET in the APR case
- JK_INET6 is always set to AF_INET6 in the IPv6 case,
even when APR is used
Fixed that. Although all the same since APR_INET6 is always AF_INET6
There are two places in common/jk_connect.c which use APR_HAVE_IPV6 and
not JK_HAVE_IPV6. is this intentional?
Yes, both APR_HAVE_IPV6 and APR_INET/APR_INET6 usage is intentional to have
clarity inside strictly APR code. Those flags are the same anyhow.
Regards
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
