2014-02-11 18:57 GMT+04:00 Mark Thomas <ma...@apache.org>: > On 11/02/2014 14:38, Konstantin Kolinko wrote: >> 2014-02-11 17:32 GMT+04:00 Mark Thomas <ma...@apache.org>: >> I see you also took care of metadata-complete=\"true\". OK. >> >> The following also comes to mind: >> <filter-mapping>, <servlet-mapping> in 2.4 do not support multiple >> <url-pattern> elements. >> (Each pattern needs its own <**-mapping> element). > > With validation enabled, a 2.4 source with multiple url-pattern elements > will be rejected when it is first parsed so the code won't reach the > generated of the "merged" web.xml in that case. > > I think this is true generally. The "merged" output for anything pre 3.0 > is going to be effectively a copy of the original web.xml so any errors > should be picked up on the initial validation. >
Just from my memory (I have not re-tested it yet), I think merged web.xml = (copy of WEB-INF/web.xml + default conf/web.xml). The conf/web.xml file may be edited by administrator and may contain constructs from later versions of specification. >> There might be some other options (inherited from the default >> conf/web.xml) that do not make sense in previous versions. > > The defaults have been handled (else the new tests would not pass). > > I don't think there are any edge cases I missed but there are enough > moving parts that there might be. I'm happy fixing those edge cases as > and when they arise. OK. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
