On 5 February 2014 15:14, Mark Thomas <ma...@apache.org> wrote: > On 05/02/2014 14:56, Maxim Kirilov wrote: >> Hi, >> >> I've noticed that some code inside *handshake()* method can be omitted. >> After executing the >> call to: *ssl.startHandshake()*, according to SSLSocket >> <http://docs.oracle.com/javase/7/docs/api/javax/net/ssl/SSLSocket.html#startHandshake%28%29>javadoc, >> after returning from this call the negotiated handshake is complete. So the >> following code that tries to read bytes from the socket >> is useless since errors during handshake process would be thrown earlier. >> >> Am I missing something? > > Look at the history of that file in svn to see why the code is there. > Once you know why that code was written, you can make an informed > decision as to whether or not it should still be there.
If the svn log is necessary to understand the code, it seems to me that the code needs to be commented with the relevant information. After all, the ASF releases source, and that does not include the svn history. > Mark > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
