[Bug 56096] Setting rmiBindAddress on JmxRemoteLifecycleListener prevents tomcat from starting

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=56096

--- Comment #1 from Jim Talbut <jim-apa...@spudsoft.co.uk> ---
Diff of a fix that works for me:
Index: java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java
===================================================================
--- java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java    
(revision 1563195)
+++ java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java    
(working copy)
@@ -255,7 +255,7 @@


             // Create the Platform server
-            csPlatform = createServer("Platform", rmiRegistryPortPlatform,
+            csPlatform = createServer("Platform", rmiBindAddress,
rmiRegistryPortPlatform,
                     rmiServerPortPlatform, env, csf, ssf,
                     ManagementFactory.getPlatformMBeanServer());

@@ -264,7 +264,7 @@
         }
     }

-    private JMXConnectorServer createServer(String serverName,
+    private JMXConnectorServer createServer(String serverName, String
bindAddress,
             int theRmiRegistryPort, int theRmiServerPort,
             HashMap<String,Object> theEnv, RMIClientSocketFactory csf,
             RMIServerSocketFactory ssf, MBeanServer theMBeanServer) {
@@ -278,12 +278,20 @@
                     serverName, Integer.toString(theRmiRegistryPort)), e);
             return null;
         }
+
+        if (bindAddress == null) {
+            bindAddress = "localhost";
+        }

         // Build the connection string with fixed ports
         StringBuilder url = new StringBuilder();
-        url.append("service:jmx:rmi://localhost:");
+        url.append("service:jmx:rmi://");
+        url.append(bindAddress);
+        url.append(":");
         url.append(theRmiServerPort);
-        url.append("/jndi/rmi://localhost:");
+        url.append("/jndi/rmi://");
+        url.append(bindAddress);
+        url.append(":");
         url.append(theRmiRegistryPort);
         url.append("/jmxrmi");
         JMXServiceURL serviceUrl;

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org