On 24/01/2014 12:41, Konstantin Kolinko wrote:
> 2014/1/24 Mark Thomas <ma...@apache.org>:
>> On 23/01/2014 19:05, Konstantin Kolinko wrote:
>>
> 
> 
> One more:
>   as Rainer noted in the [VOTE] thread,  apparently your key is
> missing from the KEYS file.
> http://markmail.org/message/4dlcb2nzhpcycxj5
> 
>> - build.properties.default differs in revision header between svn tag and 
>> src distro (but not in any functional content)
> 
> The different line:
> # $Id: build.properties.default 1557990 2014-01-14 09:20:46Z markt $
> # $Id: build.properties.default 1559233 2014-01-17 19:34:29Z markt $
> 
> I wonder what it was (building a release before tagging, or missing an
> "svn update"?

It was checkout, tag, build. I didn't build from an export of the tag
(which I normally do)

> Anyway I think we will be removing those $Id keywords as we are
> looking forward to Git.
> 
>> - bin tgz seems to contain DOS line ends in many files inside bundled 
>> webapps, bin/catalina-tasks.xml and RELEASE-NOTES.
> 
> Not a stopper.
> It should be possible to port   <patternset id="text.files" > from
> build.xml of TC7.
> There are already two proposed patched for dist.xml, so I'll wait
> until those are reviewed first.

OK.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to