-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 22/01/2014 20:48, Christopher Schultz wrote:
>> I'll start again and address my primary concern - the duplicate >> code. The other aspects I'm happy to think about / discuss >> further with a view to possibly coming back to them later. > > Could this be done more simply by providing a pair of utility > methods to do the enter/exit work rather than treating them as > events to be "handled"? That way, they can be invoked directly by > components that need them and ignored by those that don't. I thought about that. There is some coupling between the entry and exit methods (the class loader) that the caller would need to retain and some standard try/finally plumbing. There is also an optimisation not to try to change the class loader if there is no need to do so. In an effort to reduce this common code for every caller, I started down a different route. I do wonder if the entry/exit approach might end up being cleaner as even with my approach, you end up with some not so nice exception handling. I'll see what folks think of the patch so far and maybe explore the entry/exit option as well. Mark -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJS4DAnAAoJEBDAHFovYFnneMoP/2oA7IeOH+e7kENRJauAIQT9 2RqHHbfbE54m27PQUk8JtstskokT/p0AoTmrELo9VfJocgWKAjzD39+Zhsm8YgVk 9Z+eW25rheG/YDYTBHxNAMAl79EQhBDzyVL+04Ltgn11PLD9uqZR4HdOdietFXQc wOXPW/hnnTbPXAXpK+EsXXPU5JDskjUIoXxWw7jjYX+MUHRsbnlbc8r9ky17sX3B kyjcjLYGCXuB5zFzwVKzFGhA4Kx9vcLYq3Fw/bA1qf64JA9F7BljFnhxaotFVshQ WIFjNl/g7ZwZV717iPUvUaP+/M1/Mq4EiE5iPRL+k8tGOBMR8A88z4dQ1nPmrsC/ HrJ7mJIaXKoyAj0GGmCcdSG1IlqINQa/zxe2LVZ6p2JsFA7ryNf0vvfzo4OSVqBP M0A8PcC6kyrHlQ24SyGRfqcMzTiZdHQ0sFS1uYBbESkuyJ9ooxTR2/eCarzemvj6 KIUOqgDJcnHaHI/zjelrC5vBWlWIyZX2+AI27moO34YC5I3KIJ9DhJ99KjumGZup PdMhszy2nFXHE2s9Q4H7mz5MJWQYmCYF/ecJV3evWgicA1EFVoM0jQfGRwRYTuhe QdPD8ljAa7VvGZAcXcqfUDjmQ+l9SX/9nNLGIIEKLT+pHNsiL0WRPCGzxFGvOMQA kppqlPlBvNJdecCKPVPb =TamI -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
