https://issues.apache.org/bugzilla/show_bug.cgi?id=55974

            Bug ID: 55974
           Summary: Honor the order when reporting XML parsing errors and
                    warnings in XmlErrorHandler class
           Product: Tomcat 7
           Version: 7.0.47
          Hardware: PC
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: knst.koli...@gmail.com

Originally reported in comment 1 of bug 55973.

o.a.t.util.descriptor.XmlErrorHandler class stores the errors and warnings in a
HashSet. A hashset does not preserve ordering.

If there are several errors, then

a) When all errors are printed (e.g. via XmlErrorHandler#logFindings(...)),
their order is random.

b) When only one error is reported (e.g. by code added in r1552826), the one
error is chosen randomly.

The ordering can be preserved if the collection is stored as LinkedHashSet or
an ArrayList. Is there a benefit of using a 'set' here, or a 'list' would
suffice?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to