On 24/12/2013 23:42, Rainer Jung wrote: > On 19.12.2013 19:38, Mark Thomas wrote: >> The proposed Apache Tomcat 8.0.0 release candidate 10 is now available >> for voting.
As always, many thanks for the detailed review. > - One special observation in unit tests: Test > org.apache.catalina.core.TestDefaultInstanceManager throws 3 > NullPointerExceptions, that seem to indicate a broken test (see below). Fixed. > - JMX shows that websocket filter is configured for all default apps. > I didn't check, where this comes from, but should it really be > active by default? It is working as designed - whether the design is right is a different question. I have a TODO to provide a container specific way to disable unwanted SCIs on a per context basis. > - MBeans "Catalina:context=/...,host=localhost,type=WebResourceRoot" > and > "Catalina:context=/...,host=localhost,name=Cache,type=WebResourceRoot" > very similar in name (same type). > All of the numeric data moved from the first to the second > (plus additional interesting data in the second), in the first it > is only left traceLockedFiles, stateName, cachingAllowed, > traceResources and allowLinking which is all boolean or enum type. > Should we make the two MBeans differ by "type"? My primary motivation here was to a) move all the caching attributes to a new JMX object and b) have the cache appear as a "sub-object" to the resources when using JConsole with default options. I'm happy with any tweaks folks want to make as long as those two requirements are met. > - Same MBean: new attributes traceLockedFiles (boolean) and > traceResources (Array): should the second be named tracedResources > (additional "d") to distinguish the Array list of resources from the > boolean to trace or not to trace switch? I need to do some clean-up here. I also need to align attribute names between the Context and the Cache. This is on my TODO list for the next release. Thanks again, Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
