On 11.12.2013 10:41, Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.49 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.49/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-042/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_49/ > > The proposed 7.0.49 release is: > [X] Broken - do not release > [ ] Stable - go ahead and release as 7.0.49 Stable
Don't shoot the messenger, although in this case I'm also the culprit: after 7.0.47 we updated our commons-logging dependency from 1.1.1 to 1.1.3. As part of that I kept the Log4J dependency on 1.2.12 because I wanted to minimize update risks for users. Unfortunately CL 1.1.3 wants Log4J 1.2.17 to build its Log4J adapters which we ship in the extras jar file. The currently prepared adapter extras jar thus no longer contains the log4j adapter, which I think is important. I fixed our Log4J dependency to use 1.2.17 and the build of the extras logging jars now again works for me. Nevertheless I also see three test suite failures, which might again be sporadical: 1) nio org.apache.catalina.websocket.TestWebSocket Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 15.045 sec Testcase: testKey took 3.834 sec Testcase: testBug53339 took 10.306 sec Caused an ERROR Read timed out java.net.SocketTimeoutException: Read timed out at java.net.SocketInputStream.socketRead0(Native Method) at java.net.SocketInputStream.read(SocketInputStream.java:152) at java.net.SocketInputStream.read(SocketInputStream.java:122) at java.net.SocketInputStream.read(SocketInputStream.java:210) at org.apache.catalina.websocket.TestWebSocket$WebSocketClient.readMessage(TestWebSocket.java:456) at org.apache.catalina.websocket.TestWebSocket$WebSocketClient.access$300(TestWebSocket.java:383) at org.apache.catalina.websocket.TestWebSocket.testBug53339(TestWebSocket.java:327) Testcase: testDetectWrongVersion took 0.225 sec Testcase: testNoUpgrade took 0.211 sec Testcase: testNoConnection took 0.154 sec Testcase: testSimple took 0.234 sec 2) nio org.apache.catalina.loader.TestWebappClassLoaderMemoryLeak Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.813 sec Testcase: testTimerThreadLeak took 3.759 sec FAILED Timer thread still running junit.framework.AssertionFailedError: Timer thread still running at org.apache.catalina.loader.TestWebappClassLoaderMemoryLeak.testTimerThreadLeak(TestWebappClassLoaderMemoryLeak.java:72) although the test output says: Dec 12, 2013 12:29:49 PM org.apache.catalina.loader.WebappClassLoader clearReferencesStopTimerThread SEVERE: The web application [] appears to have started a TimerThread named [leaked-thread] via the java.util.Timer API but has failed to stop it. To prevent a memory leak, the timer (and hence the associated thread) has been forcibly canceled. 3) apr org.apache.catalina.websocket.TestWebSocket Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 9.261 sec Testcase: testKey took 4.565 sec Caused an ERROR Failed to stop component [StandardServer[-1]] org.apache.catalina.LifecycleException: Failed to stop component [StandardServer[-1]] at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236) at org.apache.catalina.startup.Tomcat.stop(Tomcat.java:351) at org.apache.catalina.startup.TomcatBaseTest.tearDown(TomcatBaseTest.java:161) Caused by: org.apache.catalina.LifecycleException: Failed to stop component [StandardService[Tomcat]] at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236) at org.apache.catalina.core.StandardServer.stopInternal(StandardServer.java:753) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232) Caused by: org.apache.catalina.LifecycleException: Failed to stop component [StandardEngine[Tomcat]] at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236) at org.apache.catalina.core.StandardService.stopInternal(StandardService.java:502) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232) Caused by: org.apache.catalina.LifecycleException: A child container failed during stop at org.apache.catalina.core.ContainerBase.stopInternal(ContainerBase.java:1186) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232) Testcase: testBug53339 took 0.466 sec Testcase: testDetectWrongVersion took 1.821 sec Testcase: testNoUpgrade took 0.769 sec Testcase: testNoConnection took 0.741 sec Testcase: testSimple took 0.825 sec The stop problem seems to be due to the following ConcurrentModificationException: Dec 12, 2013 1:07:37 PM org.apache.coyote.AbstractProtocol pause INFO: Pausing ProtocolHandler ["http-apr-127.0.0.1-auto-1-59835"] Dec 12, 2013 1:07:37 PM org.apache.catalina.core.StandardService stopInternal INFO: Stopping service Tomcat Dec 12, 2013 1:07:37 PM org.apache.catalina.loader.WebappClassLoader clearReferencesThreads SEVERE: The web application [] appears to have started a thread named [http-apr-127.0.0.1-auto-1-exec-2] but has failed to stop it. This is very likely to create a memory leak. Dec 12, 2013 1:07:37 PM org.apache.catalina.core.ContainerBase stopInternal SEVERE: A child container failed during stop java.util.concurrent.ExecutionException: org.apache.catalina.LifecycleException: Failed to stop component [StandardEngine[Tomcat].StandardHost[localhost].StandardContext[]] at java.util.concurrent.FutureTask.report(FutureTask.java:122) at java.util.concurrent.FutureTask.get(FutureTask.java:188) at org.apache.catalina.core.ContainerBase.stopInternal(ContainerBase.java:1179) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232) at org.apache.catalina.core.ContainerBase$StopChild.call(ContainerBase.java:1575) at org.apache.catalina.core.ContainerBase$StopChild.call(ContainerBase.java:1564) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) Caused by: org.apache.catalina.LifecycleException: Failed to stop component [StandardEngine[Tomcat].StandardHost[localhost].StandardContext[]] at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236) ... 6 more Caused by: org.apache.catalina.LifecycleException: Failed to stop component [WebappLoader[]] at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236) at org.apache.catalina.core.StandardContext.stopInternal(StandardContext.java:5690) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232) ... 6 more Caused by: java.util.ConcurrentModificationException at java.util.HashMap$HashIterator.nextEntry(HashMap.java:926) at java.util.HashMap$ValueIterator.next(HashMap.java:954) at org.apache.juli.ClassLoaderLogManager.resetLoggers(ClassLoaderLogManager.java:360) at org.apache.juli.ClassLoaderLogManager.reset(ClassLoaderLogManager.java:336) at org.apache.juli.logging.LogFactory.release(LogFactory.java:330) at org.apache.catalina.loader.WebappClassLoader.clearReferences(WebappClassLoader.java:2000) at org.apache.catalina.loader.WebappClassLoader.stop(WebappClassLoader.java:1890) at org.apache.catalina.loader.WebappLoader.stopInternal(WebappLoader.java:662) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232) ... 8 more I'm really sorry that you have such a hard time during your first TC 7 releases. Be assured that past experience shows it should typically be much less hassle in the future. Regards, Rainer --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org