Author: markt
Date: Tue Nov 26 14:07:45 2013
New Revision: 1545665
URL: http://svn.apache.org/r1545665
Log:
Remove the option to use schema validation for *.jspx and *.tagx files
Modified:
tomcat/trunk/java/org/apache/catalina/Context.java
tomcat/trunk/java/org/apache/catalina/Globals.java
tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/trunk/java/org/apache/catalina/startup/FailedContext.java
tomcat/trunk/java/org/apache/jasper/Constants.java
tomcat/trunk/java/org/apache/jasper/JspC.java
tomcat/trunk/java/org/apache/jasper/compiler/JspDocumentParser.java
tomcat/trunk/test/org/apache/catalina/core/TesterContext.java
tomcat/trunk/test/org/apache/jasper/compiler/TestJspDocumentParser.java
tomcat/trunk/webapps/docs/config/context.xml
Modified: tomcat/trunk/java/org/apache/catalina/Context.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Context.java?rev=1545665&r1=1545664&r2=1545665&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/Context.java (original)
+++ tomcat/trunk/java/org/apache/catalina/Context.java Tue Nov 26 14:07:45 2013
@@ -635,24 +635,6 @@ public interface Context extends Contain
/**
- * Will the parsing of *.jspx and *.tagx files for this Context be
performed
- * by a validating parser?
- *
- * @return true if validation is enabled.
- */
- public boolean getXmlValidationJspDoc();
-
-
- /**
- * Controls whether the parsing of *.jspx and *.tagx files for this Context
- * will be performed by a validating parser.
- *
- * @param xmlValidationJspDoc true to enable xml validation
- */
- public void setXmlValidationJspDoc(boolean xmlValidationJspDoc);
-
-
- /**
* Get the Jar Scanner to be used to scan for JAR resources for this
* context.
* @return The Jar Scanner configured for this context.
Modified: tomcat/trunk/java/org/apache/catalina/Globals.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Globals.java?rev=1545665&r1=1545664&r2=1545665&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/Globals.java (original)
+++ tomcat/trunk/java/org/apache/catalina/Globals.java Tue Nov 26 14:07:45 2013
@@ -279,14 +279,4 @@ public final class Globals {
*/
public static final String JASPER_XML_VALIDATION_TLD_INIT_PARAM =
"org.apache.jasper.XML_VALIDATE_TLD";
-
-
- /**
- * Name of the ServletContext init-param that determines if the JSP engine
- * should validate *.jspx and *.tagx files when parsing them.
- * <p>
- * This must be kept in sync with org.apache.jasper.Constants
- */
- public static final String JASPER_XML_VALIDATION_DOC_INIT_PARAM =
- "org.apache.jasper.XML_VALIDATE_DOC";
}
Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java?rev=1545665&r1=1545664&r2=1545665&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java Tue Nov
26 14:07:45 2013
@@ -309,9 +309,6 @@ public class ApplicationContext
if (Globals.JASPER_XML_VALIDATION_TLD_INIT_PARAM.equals(name) &&
context.getTldValidation()) {
return "true";
- } else if (Globals.JASPER_XML_VALIDATION_DOC_INIT_PARAM.equals(name) &&
- context.getXmlValidationJspDoc()) {
- return "true";
}
return parameters.get(name);
}
@@ -330,9 +327,6 @@ public class ApplicationContext
if (context.getTldValidation()) {
names.add(Globals.JASPER_XML_VALIDATION_TLD_INIT_PARAM);
}
- if (context.getXmlValidationJspDoc()) {
- names.add(Globals.JASPER_XML_VALIDATION_DOC_INIT_PARAM);
- }
return Collections.enumeration(names);
}
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardContext.java?rev=1545665&r1=1545664&r2=1545665&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/core/StandardContext.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Tue Nov 26
14:07:45 2013
@@ -695,13 +695,6 @@ public class StandardContext extends Con
/**
- * Attribute value used to turn on/off XML validation for *.jspx and *.tagx
- * files.
- */
- private boolean xmlValidationJspDoc = false;
-
-
- /**
* Attribute value used to turn on/off XML namespace validation
*/
private boolean webXmlNamespaceAware = Globals.STRICT_SERVLET_COMPLIANCE;
@@ -6405,18 +6398,6 @@ public class StandardContext extends Con
}
- @Override
- public void setXmlValidationJspDoc(boolean webXmlValidationJspDoc) {
- this.xmlValidationJspDoc = webXmlValidationJspDoc;
- }
-
-
- @Override
- public boolean getXmlValidationJspDoc() {
- return xmlValidationJspDoc;
- }
-
-
/**
* Support for "stateManageable" JSR77
*/
Modified: tomcat/trunk/java/org/apache/catalina/startup/FailedContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/FailedContext.java?rev=1545665&r1=1545664&r2=1545665&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/startup/FailedContext.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/FailedContext.java Tue Nov 26
14:07:45 2013
@@ -461,11 +461,6 @@ public class FailedContext extends Lifec
public void setTldValidation(boolean tldValidation){ /* NO-OP */ }
@Override
- public boolean getXmlValidationJspDoc() { return false; }
- @Override
- public void setXmlValidationJspDoc(boolean xmlValidationJspDoc) { /* NO-OP
*/ }
-
- @Override
public JarScanner getJarScanner() { return null; }
@Override
public void setJarScanner(JarScanner jarScanner) { /* NO-OP */ }
Modified: tomcat/trunk/java/org/apache/jasper/Constants.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/Constants.java?rev=1545665&r1=1545664&r2=1545665&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/jasper/Constants.java (original)
+++ tomcat/trunk/java/org/apache/jasper/Constants.java Tue Nov 26 14:07:45 2013
@@ -160,14 +160,4 @@ public class Constants {
*/
public static final String XML_VALIDATION_TLD_INIT_PARAM =
"org.apache.jasper.XML_VALIDATE_TLD";
-
-
- /**
- * Name of the ServletContext init-param that determines if the XML parsers
- * used for *.jspx and *.tagx files will be validating or not.
- * <p>
- * This must be kept in sync with org.apache.catalina.Globals
- */
- public static final String XML_VALIDATION_DOC_INIT_PARAM =
- "org.apache.jasper.XML_VALIDATE_DOC";
}
Modified: tomcat/trunk/java/org/apache/jasper/JspC.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/JspC.java?rev=1545665&r1=1545664&r2=1545665&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/jasper/JspC.java (original)
+++ tomcat/trunk/java/org/apache/jasper/JspC.java Tue Nov 26 14:07:45 2013
@@ -134,7 +134,6 @@ public class JspC extends Task implement
protected static final String SWITCH_SMAP = "-smap";
protected static final String SWITCH_DUMP_SMAP = "-dumpsmap";
protected static final String SWITCH_VALIDATE_TLD = "-validateTld";
- protected static final String SWITCH_VALIDATE_DOC = "-validateDoc";
protected static final String SHOW_SUCCESS ="-s";
protected static final String LIST_ERRORS = "-l";
protected static final int INC_WEBXML = 10;
@@ -166,7 +165,6 @@ public class JspC extends Task implement
protected boolean trimSpaces = false;
protected boolean genStringAsCharArray = false;
protected boolean validateTld;
- protected boolean validateJspDoc;
protected boolean xpoweredBy;
protected boolean mappedFile = false;
protected boolean poolingEnabled = true;
@@ -375,8 +373,6 @@ public class JspC extends Task implement
smapDumped = true;
} else if (tok.equals(SWITCH_VALIDATE_TLD)) {
setValidateTld(true);
- } else if (tok.equals(SWITCH_VALIDATE_DOC)) {
- setValidateJspDoc(true);
} else {
if (tok.startsWith("-")) {
throw new JasperException("Unrecognized option: " + tok +
@@ -864,14 +860,6 @@ public class JspC extends Task implement
return validateTld;
}
- public void setValidateJspDoc( boolean b ) {
- this.validateJspDoc = b;
- }
-
- public boolean isValidateJspDoc() {
- return validateJspDoc;
- }
-
public void setListErrors( boolean b ) {
listErrors = b;
}
@@ -1449,9 +1437,6 @@ public class JspC extends Task implement
URL resourceBase = new
File(uriRoot).getCanonicalFile().toURI().toURL();
context = new JspCServletContext(log, resourceBase, classLoader);
- if (isValidateJspDoc()) {
- context.setInitParameter(Constants.XML_VALIDATION_DOC_INIT_PARAM,
"true");
- }
if (isValidateTld()) {
context.setInitParameter(Constants.XML_VALIDATION_TLD_INIT_PARAM,
"true");
}
Modified: tomcat/trunk/java/org/apache/jasper/compiler/JspDocumentParser.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/JspDocumentParser.java?rev=1545665&r1=1545664&r2=1545665&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/jasper/compiler/JspDocumentParser.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/JspDocumentParser.java Tue Nov
26 14:07:45 2013
@@ -28,7 +28,6 @@ import javax.servlet.jsp.tagext.TagLibra
import javax.xml.parsers.SAXParser;
import javax.xml.parsers.SAXParserFactory;
-import org.apache.jasper.Constants;
import org.apache.jasper.JasperException;
import org.apache.jasper.JspCompilationContext;
import org.apache.tomcat.util.descriptor.tld.TldResourcePath;
@@ -162,13 +161,10 @@ class JspDocumentParser
jspDocParser.isTop = false;
}
- boolean validate = Boolean.parseBoolean(
-
pc.getJspCompilationContext().getServletContext().getInitParameter(
- Constants.XML_VALIDATION_DOC_INIT_PARAM));
- jspDocParser.isValidating = validate;
+ jspDocParser.isValidating = false;
// Parse the input
- SAXParser saxParser = getSAXParser(validate, jspDocParser);
+ SAXParser saxParser = getSAXParser(false, jspDocParser);
InputSource source = JspUtil.getInputSource(path, jar,
jspDocParser.ctxt);
try {
saxParser.parse(source, jspDocParser);
Modified: tomcat/trunk/test/org/apache/catalina/core/TesterContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/core/TesterContext.java?rev=1545665&r1=1545664&r2=1545665&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/catalina/core/TesterContext.java (original)
+++ tomcat/trunk/test/org/apache/catalina/core/TesterContext.java Tue Nov 26
14:07:45 2013
@@ -635,16 +635,6 @@ public class TesterContext implements Co
}
@Override
- public boolean getXmlValidationJspDoc() {
- return false;
- }
-
- @Override
- public void setXmlValidationJspDoc(boolean xmlValidationJspDoc) {
- // NO-OP
- }
-
- @Override
public void setXmlValidation(boolean xmlValidation) {
// NO-OP
}
Modified:
tomcat/trunk/test/org/apache/jasper/compiler/TestJspDocumentParser.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/jasper/compiler/TestJspDocumentParser.java?rev=1545665&r1=1545664&r2=1545665&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/jasper/compiler/TestJspDocumentParser.java
(original)
+++ tomcat/trunk/test/org/apache/jasper/compiler/TestJspDocumentParser.java Tue
Nov 26 14:07:45 2013
@@ -25,10 +25,8 @@ import javax.xml.parsers.DocumentBuilder
import javax.xml.parsers.DocumentBuilderFactory;
import org.junit.Assert;
-import org.junit.Ignore;
import org.junit.Test;
-import org.apache.catalina.Context;
import org.apache.catalina.startup.Tomcat;
import org.apache.catalina.startup.TomcatBaseTest;
import org.apache.tomcat.util.buf.ByteChunk;
@@ -121,14 +119,12 @@ public class TestJspDocumentParser exten
}
@Test
- @Ignore
public void testSchemaValidation() throws Exception {
Tomcat tomcat = getTomcatInstance();
File appDir = new File("test/webapp");
// app dir is relative to server home
- Context context = tomcat.addWebapp(null, "/test",
appDir.getAbsolutePath());
- context.setXmlValidationJspDoc(true);
+ tomcat.addWebapp(null, "/test", appDir.getAbsolutePath());
tomcat.start();
Modified: tomcat/trunk/webapps/docs/config/context.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/context.xml?rev=1545665&r1=1545664&r2=1545665&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/config/context.xml (original)
+++ tomcat/trunk/webapps/docs/config/context.xml Tue Nov 26 14:07:45 2013
@@ -553,15 +553,6 @@
penalty.</p>
</attribute>
- <attribute name="xmlValidationJspDoc" required="false">
- <p>If the value of this flag is <code>true</code>, the parsing of
- <code>*.jspx</code> and <code>*.tagx</code> files for this web
- application will use a validating parser. Before enabling this option
- users should review section JSP.6.2.4 of the JSP 2.3 specification. The
- default value will be <code>false</code>. Setting this attribute to
- <code>true</code> will incur a performance penalty.</p>
- </attribute>
-
</attributes>
</subsection>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
