https://issues.apache.org/bugzilla/show_bug.cgi?id=46263

--- Comment #8 from Christopher Schultz <ch...@christopherschultz.net> ---
Your patch looks okay to me with one minor exception: it would be better to use
the StringManager for strings instead of hard-coded ones. Look for uses of
"sm.getString" for examples.

On the other hand, I'm not sure how it makes much of a difference to deploy
MY-GREAT-APP-v1.2.3.4.war instead of MY-GREAT-APP#1.2.3.4.war.

Also, if I'm not mistaken, the patch you have written does not allow for
parallel deployment: it will essentially perform an undeploy/redeploy. During
the "reload", clients will experience at least a pause.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to