On Nov 12, 2013, at 8:53 AM, Mark Thomas <ma...@apache.org> wrote: > On 12/11/2013 15:27, Jeremy Boynes wrote: >> On Nov 12, 2013, at 5:00 AM, ma...@apache.org wrote: >> >>> Author: markt Date: Tue Nov 12 13:00:03 2013 New Revision: >>> 1541041 >>> >>> URL: http://svn.apache.org/r1541041 Log: Replace >>> TldLocationsCache with the new TldCache that also caches the >>> contents of the TLDs. This is the next step in the refactoring of >>> TLD handling. >> >> How far do you intend to go with these changes? I was just starting >> to get back to them and don't want to conflict. > > I was planning on completing the removal of TldLocation. I'm currently > working my way through understanding what that means.
I'd started by trying to remove the parsing code from TagLibraryInfoImpl,
making a thin decorator for a TaglibXml that could be shared (given the
TLIImpls are page/compilation specific due to both prefix and the reference to
other TLIs). IIRC, that worked for tags but there was a coupling somewhere in
the TagFileProcessor call used to populate the TagInfo for a tag file. I was
trying to figure out why
ctxt.setTagFileJarResource(path, jar);
was needed in before calling it and how #46471 had been fixed.
In investigating, I was also tempted to try and separate the directive and load
processing (visitors) in TagFileProcessor and see if there was a way to only do
that once.
I should have more time to contribute over the next couple of weeks and could
pick this up again if you've not got too far.
Cheers
Jeremy
signature.asc
Description: Message signed with OpenPGP using GPGMail
