On 11/11/2013 17:17, Konstantin Kolinko wrote: > Regarding the patch, > http://people.apache.org/~markt/patches/2013-11-11-bug55749-tc6.patch > > [[[ > - if (initialized) > + if (initialized || rootPool != 0) > return; > ]]] > > The above change in init() means that AprEndpoint.start() wouldn't > notice the failure. It will continue the startup sequence and fail in > some obscure way. > > I meant something like this, to make the initialization to fail: > (not tested) > [[[ > if (initialized) > return; > > + if (rootPool != 0) > + throw new Exception("AprEndpoint initialization failed. > See previous log messages."); > ]]]
I see what you mean. Proposed patch updated. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
