On 13/10/2013 15:33, Konstantin Preißer wrote: > Mark, > >> -----Original Message----- >> From: Mark Thomas [mailto:ma...@apache.org] >> Sent: Sunday, October 13, 2013 3:58 PM >> To: Tomcat Developers List >> Subject: Re: svn commit: r1531680 - >> /tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/web.xml >> >> On 13/10/2013 13:30, kpreis...@apache.org wrote: >>> Author: kpreisser >>> Date: Sun Oct 13 12:30:56 2013 >>> New Revision: 1531680 >>> >>> URL: http://svn.apache.org/r1531680 >>> Log: >>> Allow the JSR 356 WebSocket examples using the programmatic API >> (Endpoint subclasses) to work as they use a ServletContextListener that has >> @WebListener annotation, which would not be called with metadata- >> complete="true". >> >> That appears to have triggered a number of CI failures. > > OK, can you give me a hint why buildbot fails?
The SCI doesn't run when using the Tomcat class which is used by the unit tests. The unit tests that need WebSocket support explicitly enable it. Annotations are processed so changing metadata-complete means the listener is fired in a number of places where WebSocket is not available. The examples should not require metadata-complete="false" Mark > > When I look at the stdio logs for compile_1 [1], I can see NPEs in the > examples-WsConfigListener that did not happen previously (but they happen > also in trunk). I do also get these NPEs when I debug Tomcat in Eclipse as it > seems the Servlet Context did not have the > "javax.websocket.server.ServerContainer" attribute. I solved this by adding > new WsContextListener().contextInitialized(sce); > at the beginning of contextInitialized() method in the WsConfigListener. > > But I don't know if the failures have something to do with it. > (When I build Tomcat7 locally with WebSocket support and run it, then I do > not get such exceptions.) > > > Regards, > Konstantin Preißer > > [1] > http://ci.apache.org/builders/tomcat-7-trunk/builds/1469/steps/compile_1/logs/stdio > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
