https://issues.apache.org/bugzilla/show_bug.cgi?id=55642
Bug ID: 55642
Summary: TagPluginManager isConstantAttribute broken
Product: Tomcat 7
Version: 7.0.42
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: Jasper
Assignee: dev@tomcat.apache.org
Reporter: pavelcibu...@gmail.com
Function isConstantAttribute in TagPluginManager seems to be be broken.
For value "order.status" it returns false. And for value "${order.state.name}"
it returns true. According to javadoc it should be exact opposite.
Problem seems to be in Node.isLiteral function. "el!= null" should probably be
"el== null" But this function is being used elsewhere.
/**
* @return true if the attribute is specified and its value is a
* translation-time constant.
*/
public boolean TagPluginManager.isConstantAttribute(String attribute){
Node.JspAttribute attr = getNodeAttribute(attribute);
if (attr == null)
return false;
return attr.isLiteral();
}
/**
* @return true if the value is a string literal known at translation
* time.
*/
public boolean isLiteral() {
return !expression && (el != null) && !namedAttribute;
}
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
